From 45e777eb18ee38612007da477eba9e4a0ded7c53 Mon Sep 17 00:00:00 2001 From: ScarletRedMan Date: Fri, 12 Jan 2024 15:29:24 +0700 Subject: [PATCH] Fixed bug with slot limitation in picker --- .../dragonestia/picker/repository/impl/picker/ItemWrapper.java | 2 +- .../test/java/ru/dragonestia/picker/picker/RoundRobinTests.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/ru/dragonestia/picker/repository/impl/picker/ItemWrapper.java b/app/src/main/java/ru/dragonestia/picker/repository/impl/picker/ItemWrapper.java index 1fb8ef7..d516dd2 100644 --- a/app/src/main/java/ru/dragonestia/picker/repository/impl/picker/ItemWrapper.java +++ b/app/src/main/java/ru/dragonestia/picker/repository/impl/picker/ItemWrapper.java @@ -19,7 +19,7 @@ public interface ItemWrapper { } default boolean canAddUnits(int amount) { - return maxUnits() == SlotLimit.UNLIMITED_VALUE || countUnits() + amount < maxUnits(); + return maxUnits() == SlotLimit.UNLIMITED_VALUE || countUnits() + amount <= maxUnits(); } ITEM getItem(); diff --git a/app/src/test/java/ru/dragonestia/picker/picker/RoundRobinTests.java b/app/src/test/java/ru/dragonestia/picker/picker/RoundRobinTests.java index cc44a2d..467a53b 100644 --- a/app/src/test/java/ru/dragonestia/picker/picker/RoundRobinTests.java +++ b/app/src/test/java/ru/dragonestia/picker/picker/RoundRobinTests.java @@ -39,7 +39,6 @@ public class RoundRobinTests { var slots = room.getSlots(); var users = userRepository.usersOf(room); Assertions.assertTrue(slots.isUnlimited() || slots.getSlots() >= users.size()); // check slots limitation - System.out.printf("%s/%s%n", users.size(), slots.getSlots()); Assertions.assertEquals("room-2-0", room.getId()); }