Dragonestia/RoomPicker
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added more tests for other situations with RoundRobin picker (fount loop bug)

Browse Source
This commit is contained in:
Andrey Terentev 2024-01-12 15:38:14 +07:00
parent 45e777eb18
commit cfaa6e5e90
1 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
app/src/test/java/ru/dragonestia/picker/picker/RoundRobinTests.java
View File

@ -31,7 +31,7 @@ public class RoundRobinTests {
@Test @Test
void testPickingRoundRobin() { void testPickingRoundRobin() {
{ // first iteration. Take 2 users. need take 'room-2-0' { // first iteration. Take 2 users. expected take 'room-2-0'
var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(2)); var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(2));
Assertions.assertTrue(roomOpt.isPresent()); Assertions.assertTrue(roomOpt.isPresent());
@ -43,7 +43,7 @@ public class RoundRobinTests {
Assertions.assertEquals("room-2-0", room.getId()); Assertions.assertEquals("room-2-0", room.getId());
} }
{ // second iteration. Take 2 users. need take 'room-2-1' { // second iteration. Take 2 users. expected take 'room-2-1'
var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(2)); var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(2));
Assertions.assertTrue(roomOpt.isPresent()); Assertions.assertTrue(roomOpt.isPresent());
@ -54,5 +54,34 @@ public class RoundRobinTests {
Assertions.assertEquals("room-2-1", room.getId()); Assertions.assertEquals("room-2-1", room.getId());
} }
{ // third iteration. Take 1 user. expected take 'room-2-2'
var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(1));
Assertions.assertTrue(roomOpt.isPresent());
var room = roomOpt.get();
var slots = room.getSlots();
var users = userRepository.usersOf(room);
Assertions.assertTrue(slots.isUnlimited() || slots.getSlots() >= users.size()); // check slots limitation
Assertions.assertEquals("room-2-2", room.getId());
}
{ // fourth iteration. Take 4 users. expected take 'room-2-2'
var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(4));
Assertions.assertTrue(roomOpt.isPresent());
var room = roomOpt.get();
var slots = room.getSlots();
var users = userRepository.usersOf(room);
Assertions.assertTrue(slots.isUnlimited() || slots.getSlots() >= users.size()); // check slots limitation
Assertions.assertEquals("room-4-0", room.getId());
}
{ // fifth iteration. Take 9 users. expected none result
var roomOpt = roomRepository.pickFree(node, userFiller.createRandomUsers(9));
Assertions.assertTrue(roomOpt.isEmpty());
}
} }
} }